Make diff service and increase context #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Closed
bzz
approved these changes
Mar 2, 2018
Contributor
bzz
left a comment
There was a problem hiding this comment.
LGTM
👍 for tests and flexibility of diff generation
dpordomingo
approved these changes
Mar 2, 2018
Contributor
dpordomingo
left a comment
There was a problem hiding this comment.
So now diffs are going to be calculated every time in backend on every request... ok... LGTM
(let's add some cache in the future if performance is impacted)
Contributor
|
you can merge @smacker |
Contributor
Author
|
I didn't add cache now because diff generation is actually very fast. If we ever meet performance problems it will be easy to add it. |
This was referenced Mar 27, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for #112
Moving generation of diff to the handler and increasing context. In real life discussion, guys said most probably 6 lines will be alright. Later with diff generation in the handler, we will be able to increase it further or add configuration in UI or do any other improvements easier if we need.
Also, it allows to preprocess diff on backend for #176
(rendering diff is already expensive, adding preprocessing on FE would degrade user experience further)