Authorization refactoring #150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c080736 to
7bef196
Compare
carlosms
approved these changes
Feb 28, 2018
Contributor
carlosms
left a comment
There was a problem hiding this comment.
Looks good to me.
My only concern is that we need to coordinate with the infra. team to change the current GitHub application callback, and this might be easy to forget.
Maybe we should open a new issue for the 0.0.3 release with a comment to remind us of this (ping @dpordomingo)
Contributor
Author
|
Good point about callback. Only it should be coordinated with admin of the application. (I'm not sure it's infra) |
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
4829050 to
03c5af5
Compare
Contributor
|
superseded by original PR #142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
Thanks @dpordomingo for good example which I could test and implement it a little bit "righter" way: