Skip to content

OAuth provider may return error instead of code #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smacker merged 1 commit into from
Feb 21, 2018
Merged

OAuth provider may return error instead of code #144

smacker merged 1 commit into from
Feb 21, 2018

Conversation

@smacker
Copy link
Contributor

@smacker smacker commented Feb 20, 2018

Fix bug in OAuth callback handler

@smacker
OAuth provider may return error instead of code
0971dfc 
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker requested a review from bzz February 20, 2018 15:30
@bzz bzz requested a review from dpordomingo February 21, 2018 09:39
bzz
bzz approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpordomingo
Copy link
Contributor

dpordomingo commented Feb 21, 2018

@smacker you can merge

@dpordomingo dpordomingo mentioned this pull request Feb 21, 2018
Merged
@smacker smacker merged commit 270c38b into src-d:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dpordomingo dpordomingo dpordomingo approved these changes

@bzz bzz bzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smacker @dpordomingo @bzz