Skip to content

Pass env variables to frontend #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smacker merged 1 commit into from
Feb 21, 2018
Merged

Pass env variables to frontend #143

smacker merged 1 commit into from
Feb 21, 2018

Conversation

@smacker
Copy link
Contributor

@smacker smacker commented Feb 20, 2018

These changes allow to pass environmental variables to frontend.

  • It makes images more flexible (we don't set server URL inside image anymore)
  • We can change frontend behavior depends on environment now
  • Server can pass initial state to frontend if needed

@smacker smacker requested a review from bzz February 20, 2018 15:06
@smacker
Pass env variables to frontend
fe51089 
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker mentioned this pull request Feb 20, 2018
Closed
@bzz bzz requested a review from carlosms February 21, 2018 07:19
carlosms
carlosms approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bzz
bzz approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This also should enable flexible GA token passage to FE in #140

@smacker smacker merged commit 7556d94 into src-d:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@carlosms carlosms carlosms approved these changes

@bzz bzz bzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@smacker smacker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smacker @carlosms @bzz