Skip to content

Replace '/' char from version #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpordomingo merged 1 commit into from
Apr 4, 2018
Merged

Replace '/' char from version #60

dpordomingo merged 1 commit into from
Apr 4, 2018

Conversation

@dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Mar 26, 2018

when a branch has the / char and it is tested in Travis, the / char causes a conflict
(example in the release branches)

> tar -cvzf $(PROJECT)_$(TAR_VERSION)_$${os}_$${arch}.tar.gz $(PROJECT)_$${os}_$${arch}/;
tar (child): code-annotation_release/v0.0.8_linux_amd64.tar.gz: Cannot open: No such file or directory

@dpordomingo dpordomingo requested a review from mcuadros March 26, 2018 11:07
@dpordomingo
Copy link
Contributor Author

dpordomingo commented Mar 26, 2018

@smola @ajnavarro @vmarkovtsev @rporres @bzz might be interested

@dpordomingo dpordomingo mentioned this pull request Apr 3, 2018
Merged
@dpordomingo dpordomingo merged commit beb8af9 into src-d:v1 Apr 4, 2018
@dpordomingo dpordomingo deleted the replace-dir-char branch April 4, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcuadros mcuadros Awaiting requested review from mcuadros

2 more reviewers

@smacker smacker smacker approved these changes

@bzz bzz bzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpordomingo @smacker @bzz