Merged
Conversation
jfontan
approved these changes
Oct 9, 2018
kuba--
reviewed
Oct 9, 2018
docs/using-borges/key-concepts.md
Outdated
| ## Borges packer | ||
|
|
||
| A standalone process that takes repository paths (or URLs) from a file and packs them into siva files (as a *Rooted Repository*) in the given output directory. | ||
| A standalone process that takes repository paths (or URLs) from a file and packs them into siva files (as a *Rooted Repository*) in the given output directory. The producer will automatically do this when downloading repositories. |
Contributor
There was a problem hiding this comment.
separate section about producer?
The producer will automatically do this...
Hmm this one should sound somehow better
Contributor
Author
There was a problem hiding this comment.
Do you mean adding that comment in the producer section instead of in the pack one?
Contributor
There was a problem hiding this comment.
Maybe explaining that this command is a combined producer and consumer?
This command does the same job as a files producer and consumer together without queue or database dependency.
erizocosmico
approved these changes
Oct 9, 2018
Contributor
erizocosmico
left a comment
There was a problem hiding this comment.
LGTM except for what kuba said
Contributor
Author
|
I moved the comment about the packing of siva files to the producer description and rephrased it, PTAL. |
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Move the siva comment to producer and rephrase Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> typo Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
47d8f69 to
75a4bce
Compare
kuba--
approved these changes
Oct 10, 2018
ajnavarro
approved these changes
Oct 10, 2018
jfontan
approved these changes
Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the docker tag for postgress in one of the example commands to the same one used above with
docker pull, to avoid downloading postgres twice (once for the tag, once forlatestwhich is the untagged default).Indicate the borges consumer will pack repos with siva.
Signed-off-by: Juanjo Alvarez juanjo@sourced.tech