Trim spaces from urls when running from file#352
Merged
jfontan merged 1 commit intosrc-d:masterfrom Oct 9, 2018
Merged
Conversation
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
jfontan
approved these changes
Oct 9, 2018
kuba--
approved these changes
Oct 9, 2018
erizocosmico
approved these changes
Oct 9, 2018
ajnavarro
approved these changes
Oct 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that white spaces is trimmed from the URLs read from a file.
Please note that in my tests there is an issue where urls read from a text file have an space added to the start (this space is NOT in the text file) so there is another issue that you can add from the friction log or I could add it separately.Update: there is no issue, the file really had spaces at the front of each URL but Vim wasn't jumping to it when going to the next line because of my settings, I'm an idiot, still this PR has merit to make the parsing of URLs more robust.
Signed-off-by: Juanjo Alvarez juanjo@sourced.tech