Skip to content

PHP 8.1 | File::getMemberProperties(): handle enum properties same as interface properties#3577

Merged
gsherwood merged 1 commit intosquizlabs:masterfrom
jrfnl:feature/file-getmemberprops-throw-exception-for-enums
Apr 18, 2022
Merged

PHP 8.1 | File::getMemberProperties(): handle enum properties same as interface properties#3577
gsherwood merged 1 commit intosquizlabs:masterfrom
jrfnl:feature/file-getmemberprops-throw-exception-for-enums

Conversation

@jrfnl
Copy link
Copy Markdown
Contributor

@jrfnl jrfnl commented Mar 31, 2022

Neither enums nor interfaces support properties being declared on them.

This adjusts the File::getMemberProperties() method to handle properties declared on an enum in the same way as properties declared on an interface were already being handled.

Includes unit test.

@jrfnl jrfnl force-pushed the feature/file-getmemberprops-throw-exception-for-enums branch from 7ebe36b to b926ccd Compare April 1, 2022 00:11
… properties

Neither enums nor interfaces support properties being declared on them.

This adjusts the `File::getMemberProperties() method to handle properties declared on an `enum` in the same way as properties declared on an `interface` were already being handled.

Includes unit test.
@jrfnl jrfnl force-pushed the feature/file-getmemberprops-throw-exception-for-enums branch from b926ccd to 152fa05 Compare April 1, 2022 00:18
@gsherwood gsherwood added this to the 3.7.0 milestone Apr 18, 2022
@gsherwood gsherwood merged commit 1c82e07 into squizlabs:master Apr 18, 2022
@gsherwood
Copy link
Copy Markdown
Member

Thanks

@jrfnl jrfnl deleted the feature/file-getmemberprops-throw-exception-for-enums branch April 18, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants