Skip to content

PHP 8.1: Added support for readonly keyword#3480

Merged
gsherwood merged 2 commits intosquizlabs:masterfrom
kukulich:php81-readonly
Dec 17, 2021
Merged

PHP 8.1: Added support for readonly keyword#3480
gsherwood merged 2 commits intosquizlabs:masterfrom
kukulich:php81-readonly

Conversation

@kukulich
Copy link
Copy Markdown
Contributor

@kukulich kukulich commented Nov 20, 2021

No description provided.

@kukulich kukulich mentioned this pull request Nov 20, 2021
Closed
8 tasks
@kukulich kukulich force-pushed the php81-readonly branch 3 times, most recently from 1753d8e to 2bd65e9 Compare November 20, 2021 10:58
@kukulich kukulich marked this pull request as draft November 20, 2021 10:59
@kukulich kukulich force-pushed the php81-readonly branch 9 times, most recently from a8ec2c9 to 5398ede Compare November 20, 2021 11:51
@kukulich kukulich marked this pull request as ready for review November 20, 2021 11:54
jrfnl
jrfnl reviewed Nov 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @kukulich ! I've left some notes and suggestions in-line.

@kukulich kukulich marked this pull request as draft November 20, 2021 15:03
@kukulich kukulich force-pushed the php81-readonly branch 2 times, most recently from 99f72fa to 857d0b5 Compare November 20, 2021 16:26
@kukulich kukulich marked this pull request as ready for review November 20, 2021 16:30
@kukulich kukulich force-pushed the php81-readonly branch 2 times, most recently from 0401f9d to 197cfa4 Compare November 20, 2021 18:41
@gsherwood gsherwood added this to the 3.7.0 milestone Nov 21, 2021
@kukulich kukulich mentioned this pull request Nov 21, 2021
Merged
3 tasks
@gsherwood gsherwood merged commit 21bd369 into squizlabs:master Dec 17, 2021
@gsherwood
Copy link
Copy Markdown
Member

gsherwood commented Dec 17, 2021

Thanks a lot for this contribution.

I made a couple of little changes, including adding support for readonly const. While it is a syntax error in 8.1, it still tokenizes as T_READONLY...

@kukulich kukulich deleted the php81-readonly branch December 17, 2021 07:28
This was referenced Dec 18, 2021
Merged
Merged
Merged
@jrfnl jrfnl mentioned this pull request Oct 15, 2022
Merged
@jrfnl jrfnl mentioned this pull request Jun 7, 2023
Closed
@jrfnl jrfnl mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrfnl jrfnl jrfnl left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kukulich @gsherwood @jrfnl