Added yield in Generic.LowerCaseKeyword#1458
Added yield in Generic.LowerCaseKeyword#1458gmponos wants to merge 4 commits intosquizlabs:masterfrom
Conversation
|
This is weird. The current travis failed for all PHP versions except from 7. I have 7 and it seems that's why it passed also locally. |
8b54c5a to
f083e70
Compare
|
Any help on how I can make the travis green? After the new commit it's failing only for 5.4 version but not sure how to fix it. |
| $error = 'PHP keywords must be lowercase; expected "%s" but found "%s"'; | ||
| $data = array( | ||
| strtolower($keyword), | ||
| $expected, |
There was a problem hiding this comment.
Sorry for this change I could not hold myself 😛
There was a problem hiding this comment.
You may also want to change this on line 128 below in that case.
There was a problem hiding this comment.
Done.. nice catch...
I suspect that PHPCS does not backfill for the [Edit] As a side-note: this should probably be fixed (backfilled) in the Tokenizer, rather than fixed in the sniff itself. Preferably for both the 2.x as well as the 3.x branches. |
| function (array $a) {} | ||
| const PRIVATE; | ||
| HttpStatus::CONTINUE; | ||
| function |
There was a problem hiding this comment.
This removes a very specific test case that is checking for an error that used to occur when the file ends with function (as happens when using check-as-you-type plugins). The commit is here: 88d3f29
When you see syntax errors in tests files, they are almost always there for a specific reason, so it's best to check the test file history just to be sure it's not a mistake.
|
:( Closing since this #1492 covers more cases. |
No description provided.