Skip to content

Generic.WhiteSpace.SpreadOperatorSpacingAfter does not ignore spread operator in PHP 8.1 first class callables#3694

Merged
gsherwood merged 1 commit intosquizlabs:masterfrom
jrfnl:feature/generic-spreadoperatorspacingafter-ignore-first-class-callables
Dec 18, 2022
Merged

Generic.WhiteSpace.SpreadOperatorSpacingAfter does not ignore spread operator in PHP 8.1 first class callables#3694
gsherwood merged 1 commit intosquizlabs:masterfrom
jrfnl:feature/generic-spreadoperatorspacingafter-ignore-first-class-callables

Conversation

@jrfnl
Copy link
Copy Markdown
Contributor

@jrfnl jrfnl commented Oct 16, 2022

... as in that case the spread operator does not apply to a variable/function call and the likelihood of the sniff conflicting with other sniffs which examine the spacing on the inside of parenthesis is high.

Includes unit tests.

Ref:

…in first class callables

... as in that case the spread operator does not apply to a variable/function call and the likelihood of the sniff conflicting with other sniffs which examine the spacing on the inside of parenthesis is high.

Includes unit tests.

Ref:
* https://wiki.php.net/rfc/first_class_callable_syntax
* https://3v4l.org/YTTO1
@gsherwood gsherwood added this to the 3.7.2 milestone Dec 18, 2022
@gsherwood gsherwood changed the title PHP 8.1 | Generic/SpreadOperatorSpacingAfter: ignore spread operator in first class callables Generic.WhiteSpace.SpreadOperatorSpacingAfter does not ignore spread operator in PHP 8.1 first class callables Dec 18, 2022
gsherwood added a commit that referenced this pull request Dec 18, 2022
@gsherwood gsherwood merged commit 1e1b942 into squizlabs:master Dec 18, 2022
@gsherwood
Copy link
Copy Markdown
Member

Thanks for fixing this.

@jrfnl jrfnl deleted the feature/generic-spreadoperatorspacingafter-ignore-first-class-callables branch December 18, 2022 23:34
@jrfnl
Copy link
Copy Markdown
Contributor Author

jrfnl commented Dec 18, 2022

yvw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants