Add mention of custom domain when publishing site using GitHub Actions#8155
Merged
squidfunk merged 1 commit intosquidfunk:masterfrom Apr 10, 2025
Merged
Add mention of custom domain when publishing site using GitHub Actions#8155squidfunk merged 1 commit intosquidfunk:masterfrom
squidfunk merged 1 commit intosquidfunk:masterfrom
Conversation
Owner
|
Thanks for the PR. Can we generalize this into "To publish your site on a custom domain, please refer to the MkDocs documentation"? This delegates the entire details to MkDocs, so if more things that are necessary to set up for custom domains appear in MkDocs' documentation, we don't need to change our guide. Thanks! |
Contributor
Author
|
Yes, that's a good idea. I like this better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the issue that the
CNAMEfile that GitHub creates when specifying the custom domain in the repo settings gets overwritten on the next deploy.This PR adds a sentence and refers to the MkDocs docs that explain the addition of the
CNAMEfile.