Update yaml schemas#7464
Update yaml schemas#7464FredZinelli wants to merge 12 commits intosquidfunk:masterfrom FredZinelli:master
Conversation
|
Oh dear...! I just saw the |
FredZinelli
left a comment
There was a problem hiding this comment.
Ok, looks better this time... :/
|
(Sorry for the noisy commits, I'm not used to github management/PR... 'x) ) |
I _finally_ found the batch tool... (note to self: don't create PRs at midnight...)
|
Thanks for the PR and for all your work. However, 1,444 lines changed – it's impossible for us to review this. There are definitely some things that make no sense to merge from our perspective, for example the group plugin cannot have a non-object syntax, because it just makes no sense. It would be a no-op. Additionally, combining Please cut this PR into several smaller PRs, e.g., those that just add missing MkDocs settings, and those that do fundamental changes, so they can be separately discussed and tested. You do not need to make a PR for each change introduced, but group them logically, so they are easy to reason about. Please try to make those PRs self-contained and easy to reason about, then we can think about merging them. Closing, as this is not possible to merge. |
|
Ok, no problem. I'll get back to you with something more concise. edit:
Oh, I got misled by this page, then: Seeing no colon, I thought it could be used as a "non object" like |

Hello,
I updated a bunch of yaml schemas, fixing some missing configs, and adding some new elements related to projects of mine on the way.
Fix / update:
schema.json:edit_uri_templatewas missingschema/pluigins:I added all the
material/pluginsyntaxes to each of your plugins, because I built a new theme extending yours,pyodide-mkdocs-theme(related question). So, I moved the object version in$defsand rewrote of the"oneOf"array, with 4 versions:const: pluginconst: material/pluginobject: plugin: to $defsobject: material/plugin: to $defsThis fixed on the way some inconsistencies (at least one: the
groupplugin didn't have anyconstversion, while it's talked about in material's docs)Add
theme.json: addedconst: pyodide-mkdocs-theme. This one is up to you, if you don't want to add it there, no problem on my sideplugins.json: this is the main reason for this PR I added 2 external refs for 2 of my projects: the plugin coming with my theme,pyodide_macros, and an older project of mine,mkdocs-addresses(the schema for this one is only a working stub, I didn't create the full config yet).Hoping you'll be ok with the changes.
Kind regards,
Fred
PS: I still have one red line in my
mkdocs.yml, but didn't find a way to fix it:I saw the tags you used for emojis or superfences in the config of the vscode yaml extension, but I don't get what they actually are about and couldn't make something equivalent to work with the
tabbedextension. No idea how this actually work...It's not a problem, I'm just pointing it out, in case you know how to fix it on the way...