Skip to content

added note on importance of site_url#7103

Merged
squidfunk merged 2 commits intosquidfunk:masterfrom
alexvoss:site_url
Apr 28, 2024
Merged

added note on importance of site_url#7103
squidfunk merged 2 commits intosquidfunk:masterfrom
alexvoss:site_url

Conversation

@alexvoss
Copy link
Copy Markdown
Collaborator

this was in response to
#4678 (comment)

@alexvoss alexvoss requested a review from squidfunk April 26, 2024 06:33
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We should add that the site_url setting is strongly recommended from our perspective, as without it, several features will not work, including instant loading and previews, as well as social cards.

@alexvoss alexvoss requested a review from squidfunk April 27, 2024 15:44
Copy link
Copy Markdown
Owner

@squidfunk squidfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@squidfunk squidfunk merged commit c427e1c into squidfunk:master Apr 28, 2024
@squidfunk squidfunk deleted the site_url branch April 28, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants