Add CI Configuration part for enable creation date in git-revision-date-localized plugin#6015
Closed
mendax1234 wants to merge 0 commit intosquidfunk:masterfrom
Closed
Add CI Configuration part for enable creation date in git-revision-date-localized plugin#6015mendax1234 wants to merge 0 commit intosquidfunk:masterfrom
enable creation date in git-revision-date-localized plugin#6015mendax1234 wants to merge 0 commit intosquidfunk:masterfrom
Conversation
Collaborator
|
Thanks for this. Not everything is using a CI system, though, so perhaps add a sentence that says that this is needed if people are deploying through a CI system? (M4MkDocs is used by a very wide range of users.) |
squidfunk
requested changes
Sep 14, 2023
|
|
||
| [With Github Actions](../publishing-your-site.md#with-github-actions): | ||
|
|
||
| === "Material for MkDocs" |
Owner
There was a problem hiding this comment.
Please don't copy our entire CI setup guide, as we'd now have two places where we have to maintain it. Please just clarify with a sentence that when building in a CI environment, you might need to adjust the setting when fetching the code. That's exactly what @alexvoss mentioned. Thanks.
Contributor
Author
There was a problem hiding this comment.
Ok, thanks! I will change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure whether it is suitable to use
notehere, but if not, let me know and it can be changed at any time before merging.Also, l think a simple example here would be better. However, l think doing another complete section about adding
CI workflowto your documentation site would be much better. Since l am not an expert at theCI workflow, l think maybe l can just link to theCI workflow configurationpart if it is done.