Import jsr305 and use it to mark @Nullable stuff. #307
+37
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I had 3 choices for
I’m not happy adding a dependency from Okio onto anything. I’m convincing myself that it’s okay. |
JakeWharton
approved these changes
May 2, 2017
|
Thanks for mentioning rationale. I have many times been tempted to add 305
but perhaps let my no deps dogma get the best of me and didnt. 305 is
something so common feels like standard JRE at this point.
On 2 May 2017 10:51 am, "Jesse Wilson" <notifications@github.com> wrote:
I had 3 choices for @nullable (Android, JetBrains, JSR-305). I decided to
go with JSR-305 for these reasons:
1. The package-level @ParametersAreNonnullByDefault means we don’t need
to litter annotations everywhere.
2. Guava uses it, so many applications already import it
I’m not happy adding a dependency from Okio onto anything. I’m convincing
myself that it’s okay.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#307 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD614S-VnXkkG9QRU57-316tO8SuJvIks5r1poogaJpZM4NNpzM>
.
|
Collaborator
Author
|
I’m going to try making this a provided dependency. That’d prevent it from showing up in end-users builds. It shouldn’t impact static analysis. |
The result is that IntelliJ + Kotlin correctly infers the right nullability
for Okio's APIs. I used IntelliJ's "Specify types explicitly" quick fix on
the 'a' and 'b' variables below and it did the right thing.
fun specifyTypeExplicitly(source: BufferedSource) {
val a: String? = source.readUtf8Line()
val b: String = source.readUtf8LineStrict()
}
d45207c to
2320c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result is that IntelliJ + Kotlin correctly infers the right nullability
for Okio's APIs. I used IntelliJ's "Specify types explicitly" quick fix on
the 'a' and 'b' variables below and it did the right thing.