created separate perms for windows so that windows users will no longer experience permission denied issues #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er experience permission denied issues
jdtw
approved these changes
May 16, 2022
Contributor
jdtw
left a comment
There was a problem hiding this comment.
Test this on Windows if you can?
Adding to run tests in windows environment
Removed lint-windows because code doesn't change between platforms, so we only need one linter
… available in windows
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #144
TL;DR windows does not allow 440 permissions (which were being set for key files in certstap). In reality, the key files were being given 444 permissions.
However, this was previously allowed because file permissions checking in certstrap was flawed - it was allowing files with looser permissions than expected to be used. This was fixed in #141. However, the side effect of this fix was that certstrap broke in windows due to 444 (the actual key file permissions) being looser than 440. This PR fixes this by setting special leaf perms to be 444 for windows only.