Add support for setting pathlen on CA certificates #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default when certstrap initializes a CA certificate it sets the `pathlen` X509v3 basic constraint to zero (0). This is correct if the CA will not be used in a certificate chain which includes intermediate certificates. Add a parameter to `certstrap init` to allow a user to override the `pathlen` constraint if they know that their CA will be used with intermediate certificates. By default the value is set to zero, leaving the behaviour the same as before this change if the parameter isn't overridden. c.f. https://tools.ietf.org/html/rfc5280#section-4.2.1.9 Example usage: ``` $ certstrap init -cn foo.example.com [...] $ openssl x509 -noout -text -in out/foo.example.com.crt [...] X509v3 Basic Constraints: critical CA:TRUE, pathlen:0 [...] ``` ``` $ certstrap init -cn bar.example.com --path-length 1 [...] $ openssl x509 -noout -text -in out/bar.example.com.crt [...] X509v3 Basic Constraints: critical CA:TRUE, pathlen:1 [...] ``` Fixes: square#78
|
|
|
Not sure what the status of this is but just wanted to say thanks @agy! I'm working on a blog post about testing out mTLS locally with an intermediate CA and I was able to get it all working thanks to you. |
mcpherrinm
approved these changes
Feb 26, 2021
Contributor
mcpherrinm
left a comment
There was a problem hiding this comment.
This looks fine to me but I'm not really working on this codebase anymore so I'll see if anyone else is available to merge it.
|
Thanks for the fix @agy—I ran into the same issue! |
This was referenced Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default when certstrap initializes a CA certificate it sets the
pathlenX509v3 basic constraint to zero (0). This is correct if the CAwill not be used in a certificate chain which includes intermediate
certificates.
Add a parameter to
certstrap initto allow a user to override thepathlenconstraint if they know that their CA will be used withintermediate certificates. By default the value is set to zero, leaving
the behaviour the same as before this change if the parameter isn't
overridden.
c.f. https://tools.ietf.org/html/rfc5280#section-4.2.1.9
Example usage:
Fixes: #78