update to generated binaries information #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description, related to generated binaries, is not right,
|
|
Contributor
|
@mrturkmen06 thanks for the PR! Since the instructions were written, we have removed dependency vendoring in favor of Go modules. Even though we still use |
Contributor
Author
|
@mbyczkowski Thank you very much for your explanation :) I have re-updated readme and .gitignore. I hope, it is good to go. |
mbyczkowski
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the description for generated binary is outdated, that's why I would like to update it. I hope, it is ok to merge, otherwise it could be nice to have a discussion how it should look like