Skip to content

Golang 1.17 broke Tests with crypto/x509 #121

@Robinysh

Description

@Robinysh

CreateCertificate now returns an error if the provided private key doesn't match the parent's public key.
https://go-review.googlesource.com/c/go/+/224157/

Test Logs

?       github.com/square/certstrap     [no test files]                                                                                                                                                        
=== RUN   TestParseExpiryWithSeconds                                                                                                                                                                           
--- PASS: TestParseExpiryWithSeconds (0.00s)                                                                                                                                                                   
=== RUN   TestParseExpiryWithMinutes                                                                                                                                                                           
--- PASS: TestParseExpiryWithMinutes (0.00s)                                                                                                                                                                   
=== RUN   TestParseExpiryWithHours                                                                                                                                                                             
--- PASS: TestParseExpiryWithHours (0.00s)                                                                                                                                                                     
=== RUN   TestParseExpiryWithDays                                                                                                                                                                              
--- PASS: TestParseExpiryWithDays (0.00s)                                                                                                                                                                      
=== RUN   TestParseExpiryWithMonths                                                                                                                                                                            
--- PASS: TestParseExpiryWithMonths (0.00s)                                                                                                                                                                    
=== RUN   TestParseExpiryWithYears                                                                                                                                                                             
--- PASS: TestParseExpiryWithYears (0.00s)                                                                                                                                                                     
=== RUN   TestParseExpiryWithMixed                                                                                                                                                                             
--- PASS: TestParseExpiryWithMixed (0.00s)                                                                                                                                                                     
=== RUN   TestParseInvalidExpiry                                                                                                                                                                               
--- PASS: TestParseInvalidExpiry (0.00s)                                                                                                                                                                       
=== RUN   TestRevokeCmd                                                                                                                                                                                        
    revoke_test.go:118: could not create cert host: x509: provided PrivateKey doesn't match parent's PublicKey                                                                                                 
--- FAIL: TestRevokeCmd (0.12s)                                                                                                                                                                                
FAIL                                                                                                                                                                                                           
FAIL    github.com/square/certstrap/cmd 0.122s                                                                                                                                                                 
=== RUN   TestDepotCRUD                                                                                                                                                                                        
--- PASS: TestDepotCRUD (0.01s)                                                                                                                                                                                
=== RUN   TestDepotPutNil                                                                                                                                                                                      
--- PASS: TestDepotPutNil (0.01s)                                                                                                                                                                              
=== RUN   TestDepotCheckFailure                                                                                                                                                                                
--- PASS: TestDepotCheckFailure (0.01s)                                                                                                                                                                        
=== RUN   TestDepotGetFailure                                                                                                                                                                                  
--- PASS: TestDepotGetFailure (0.01s)                                                                                                                                                                          
=== RUN   TestDepotList                                                                                                                                                                                        
--- PASS: TestDepotList (0.01s)                                                                                                                                                                                
=== RUN   TestDepotGetFile
--- PASS: TestDepotGetFile (0.01s)
PASS                                               
ok      github.com/square/certstrap/depot       0.047s
=== RUN   TestCreateCertificateAuthority
--- PASS: TestCreateCertificateAuthority (0.01s)
=== RUN   TestCreateCertificateHost
--- PASS: TestCreateCertificateHost (0.00s)
=== RUN   TestCertificateAuthorityInfo
--- PASS: TestCertificateAuthorityInfo (0.00s)
=== RUN   TestCertificateAuthorityInfoFromJSON
--- PASS: TestCertificateAuthorityInfoFromJSON (0.00s)
=== RUN   TestCertificateAuthority
--- PASS: TestCertificateAuthority (0.00s)
=== RUN   TestWrongCertificate
--- PASS: TestWrongCertificate (0.00s)
=== RUN   TestBadCertificate
--- PASS: TestBadCertificate (0.00s)
=== RUN   TestCertificateVerify
--- PASS: TestCertificateVerify (0.00s)
=== RUN   TestCreateCertificateRevocationList                                                                                                                                                        [299/1166]
--- PASS: TestCreateCertificateRevocationList (0.02s)
=== RUN   TestCertificateRevocationList
--- PASS: TestCertificateRevocationList (0.00s)
=== RUN   TestCreateCertificateSigningRequest
--- PASS: TestCreateCertificateSigningRequest (0.03s)
=== RUN   TestCertificateSigningRequest
--- PASS: TestCertificateSigningRequest (0.00s)
=== RUN   TestOldStyleCertificateSigningRequest
--- PASS: TestOldStyleCertificateSigningRequest (0.00s)
=== RUN   TestWrongCertificateSigningRequest
--- PASS: TestWrongCertificateSigningRequest (0.00s)
=== RUN   TestBadCertificateSigningRequest
--- PASS: TestBadCertificateSigningRequest (0.00s)
=== RUN   TestCreateRSAKey
--- PASS: TestCreateRSAKey (0.03s)
=== RUN   TestRSAKey                               
--- PASS: TestRSAKey (0.00s)
=== RUN   TestWrongRSAKey
--- PASS: TestWrongRSAKey (0.00s)
=== RUN   TestBadRSAKey                            
--- PASS: TestBadRSAKey (0.00s)
=== RUN   TestRSAKeyExport
--- PASS: TestRSAKeyExport (0.00s)
=== RUN   TestRSAKeyExportEncrypted
--- PASS: TestRSAKeyExportEncrypted (0.00s)
=== RUN   TestRSAKeyGenerateSubjectKeyID
--- PASS: TestRSAKeyGenerateSubjectKeyID (0.00s)
PASS                                               
ok      github.com/square/certstrap/pkix        0.092s
=== RUN   TestVersion                          
--- PASS: TestVersion (0.08s)
=== RUN   TestIp                                   
--- PASS: TestIp (0.26s)                           
=== RUN   TestNotCA                                
--- PASS: TestNotCA (2.07s)
=== RUN   TestURI                                  
--- PASS: TestURI (0.28s)
=== RUN   TestWorkflow                             
--- PASS: TestWorkflow (1.21s)
PASS                                               
ok      github.com/square/certstrap/tests       3.907s
FAIL

System
Go version: go version go1.17.1 linux/amd64
Certstrap version: 1768704
Linux version: Arch linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions