Fix Windows build #352
Merged
Fix Windows build #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables cgo for builds via `go env`, rather than via an environment variable. This should be more compatible with Windows builds.
This commit adds a new workflow that builds `certigo` for all target platforms on push, but does not create a new release. This should help to identify any newly introduced compilation issues. The configuration for the build is identical to the release workflow.
`github.com/zmap/zcrypto` currently does not compile on Windows: see zmap/zcrypto#422. This commit downgrades the dependency to the newest working version, from August 2024.
suzy-huang
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows build is currently broken. This PR contains the commits required to successfully build a new release on Windows.