Add encoding support to JCEKS package #349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a JCEKS encoder to the
jcekspackage. Previously, the package was only capable of reading JCEKS files.Internally, this commmit effectively rewrites the package.
These changes are backward compatible with the previous package API and thus do not require a new major version. However, there are several behavioral changes that have the potential to break existing code that relied on edge cases:
KeyStore.ParseWithOptionsmethod with appropriate options.The internal changes to the package introduced by this commit are substantial. Some of the highlights include:
testdatais now generated bygo generate, rather than shelling out toopensslandkeytoolat unit test time.