Fix current linter findings #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an explicit `golangci-lint` configuration that simply matches the default linters previously in use, and then fixes all current linter findings. Aside from tweaking error message strings, this commit introduces one externally visible behavior change: PEM data generated from PKCS#12 files now correctly identifies private key blocks as `RSA PRIVATE KEY` or `EC PRIVATE KEY`, whereas previously it generated invalid `PRIVATE KEY` blocks with non-PKCS#8 data. This commit lays the groundwork for more aggressive linting in the future, and identifies some additional issues via TODOs.
suzy-huang
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an explicit
golangci-lintconfiguration that simply matches the default linters previously in use, and then fixes all current linter findings.Aside from tweaking error message strings, this commit introduces one externally visible behavior change: PEM data generated from PKCS#12 files now correctly identifies private key blocks as
RSA PRIVATE KEYorEC PRIVATE KEY, whereas previously it generated invalidPRIVATE KEYblocks with non-PKCS#8 data.This commit lays the groundwork for more aggressive linting in the future, and identifies some additional issues via TODOs.