Add zlint support #286
Merged
Add zlint support #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jdtw
reviewed
Jul 26, 2022
jdtw
reviewed
Jul 29, 2022
lib/encoder.go
Outdated
| warnings = append(warnings, "Public key exponent in RSA key is less than 3") | ||
| lintRegistryOnce.Do(func() { | ||
| registry, err := lint.GlobalRegistry().Filter(lint.FilterOptions{ | ||
| IncludeSources: []lint.LintSource{lint.RFC5280, lint.CABFBaselineRequirements, lint.Community}, |
Contributor
There was a problem hiding this comment.
Sorry to be a pain, but let's leave off the CAB BR ones in this PR. For our private PKI, these don't make sense. A good improvement would be to take the sources via a flag, maybe. (Not in this PR)
jdtw
reviewed
Jul 29, 2022
jdtw
reviewed
Jul 29, 2022
jdtw
reviewed
Jul 29, 2022
jdtw
approved these changes
Jul 29, 2022
Contributor
jdtw
left a comment
There was a problem hiding this comment.
Just one minor comment about keeping backwards compatibility in the public struct.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cert warnings to use zlint with lint sources from RFC5280, CA/Browser Forum Baseline Requirements, and the zlint community.