no need to print input format when connecting to server #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpherrinm
approved these changes
Feb 28, 2020
Contributor
|
We should have test coverage over this, but in the meantime, we can open a ticket for that |
Contributor
|
discussed offline with @captiosus who will write a test |
mcpherrinm
suggested changes
Feb 28, 2020
Contributor
mcpherrinm
left a comment
There was a problem hiding this comment.
needs test to prevent regression
mcpherrinm
reviewed
Feb 28, 2020
cli/cli_test.go
Outdated
| } | ||
|
|
||
| func TestConnect(t *testing.T) { | ||
| args := []string{"connect", "--verbose", "squareup.com:443"} |
Contributor
There was a problem hiding this comment.
We should spin up a server in the test and connect to it, rather than relying on an outside source.
mcpherrinm
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #213
Only print input format when using dump. Never set this up for connect but inadvertently included print statement. Don't think functionality is useful for connect anyway so just removing the print