Don't cache the projectDir or binaryFile as part of GeneratedFileCache
#883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f803df to
a0095e5
Compare
…eCache` fixes #880 The `GeneratedFileCache` needs a reference to the current machine's project directory and the path of its binary file. These values were being written to that binary file and restored on subsequent reads. That breaks things when the same cache is used on a different machine due to remote build caching. Now, those two files are still part of `GeneratedFileCache`, but only the inner `Tables` class is actually cached.
a0095e5 to
d42a51e
Compare
JoelWilcox
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #880
The
GeneratedFileCacheneeds a reference to the current machine's project directory and the path of its binary file.These values were being written to that binary file and restored on subsequent reads. That breaks things when the same cache is used on a different machine due to remote build caching.
Now, those two files are still part of
GeneratedFileCache, but only the innerTablesclass is actually cached.