Fix foreign key idempotency failure when pgquery fallback occurs (#1147)#1148
Merged
Fix foreign key idempotency failure when pgquery fallback occurs (#1147)#1148
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix foreign key idempotency failure when pgquery fallback occurs (#1147)
The pgquery parser always created ConstraintOptions{false, false} for
foreign keys even without a DEFERRABLE clause, while the generic parser
correctly set it to nil. This mismatch caused areSameForeignKeys to
detect a false difference, leading to unnecessary FK recreation when the
desired schema was parsed by pgquery and the current schema by the
generic parser.
close #1147