Support CREATE INDEX IF NOT EXISTS in generic parser (#1142)#1146
Merged
Conversation
The generic parser didn't support CREATE INDEX IF NOT EXISTS, causing
psqldef to fall back to the pgquery parser. This led to unnecessary
foreign key constraint migrations due to differing constraintOptions
representations between the two parsers (nil vs {false, false}).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic parser didn't support CREATE INDEX IF NOT EXISTS, causing psqldef to fall back to the pgquery parser. This led to unnecessary foreign key constraint migrations due to differing constraintOptions representations between the two parsers (nil vs {false, false}).
close #1142 in favor of this PR.