Skip to content

Strip redundant casts around text/character varying#1143

Merged
gfx merged 2 commits intosqldef:masterfrom
wreulicke:fix-inconsistency-conditional-unique
Mar 3, 2026
Merged

Strip redundant casts around text/character varying#1143
gfx merged 2 commits intosqldef:masterfrom
wreulicke:fix-inconsistency-conditional-unique

Conversation

@wreulicke
Copy link
Contributor

@wreulicke wreulicke commented Feb 26, 2026

Strip redundant text/character varying casts.

current behavior

Test fails by Desired schema is not idempotent.

Note

In advance, I apologize this change is crafted by claude code except for the test case.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
schema/normalize.go 84.59% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gfx gfx added this pull request to the merge queue Mar 3, 2026
@gfx
Copy link
Contributor

gfx commented Mar 3, 2026

Thank you for the contribution!

Claude Code is okay. I've already set up CLAUDE.md / AGENTS.md for coding agents for me.

Merged via the queue into sqldef:master with commit b12fd0f Mar 3, 2026
25 checks passed
@sqldef-bot sqldef-bot bot mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants