Fix unnecessary ALTER for ENUM type default values in psqldef#1135
Merged
Fix unnecessary ALTER for ENUM type default values in psqldef#1135
Conversation
PostgreSQL stores ENUM column defaults with explicit type casts (e.g., 'pending'::order_status), but users write DEFAULT 'pending' without the cast. These were compared as different strings, causing psqldef to generate ALTER TABLE SET DEFAULT on every run. Strip identity casts (where the cast type matches the column type) before comparing default values.
Remove the column type check since this comparison is always for the same column, and PostgreSQL rejects casts to incompatible types.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
psqldefgenerates unnecessaryALTER TABLE ... SET DEFAULTstatements for columns with ENUM (or domain) type defaults on every run, even when the schema is already up to date.Why
PostgreSQL internally stores ENUM column defaults with an explicit type cast (e.g.,
'pending'::order_status), while users typically writeDEFAULT 'pending'without the cast in their schema files. The existingnormalizeExprhandles built-in type casts (text, integer, date, etc.) but not custom types like ENUMs and domains, causing the two representations to be compared as different strings.How
Added
unwrapCast()to strip remaining type casts afternormalizeExprwhen comparing default values inareSameDefaultValue(). This ensures that'pending'::order_statusand'pending'are correctly recognized as equivalent.