Fix line comment check: Do not skip comment includes multi-line SQL#1121
Merged
gfx merged 1 commit intosqldef:masterfrom Feb 4, 2026
Merged
Fix line comment check: Do not skip comment includes multi-line SQL#1121gfx merged 1 commit intosqldef:masterfrom
gfx merged 1 commit intosqldef:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Merged
winebarrel
commented
Feb 4, 2026
| logger.Printf("%s;\n", ddl) | ||
| // Skip ddlSuffix and execution for commented DDLs (e.g., "-- Skipped: ...") | ||
| if !strings.HasPrefix(ddl, "-- ") { | ||
| if !strings.HasPrefix(ddl, "-- ") && !strings.Contains(strings.TrimSpace(ddl), "\n") { |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| if !strings.HasPrefix(ddl, "-- ") && !strings.Contains(strings.TrimSpace(ddl), "\n") { | |
| if !(strings.HasPrefix(ddl, "-- ") && !strings.Contains(strings.TrimSpace(ddl), "\n")) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgqueryparser parses the followingCREATE TABLEas-- comment\ncreate table ..., but it is treated as a line comment and skipped.Fixed line comments not to be skipped if they contain
\n.