fix: preserve unique constraint when renaming column in psqldef#1103
Merged
178inaba merged 1 commit intosqldef:masterfrom Jan 8, 2026
Merged
fix: preserve unique constraint when renaming column in psqldef#1103178inaba merged 1 commit intosqldef:masterfrom
178inaba merged 1 commit intosqldef:masterfrom
Conversation
When renaming a column with a UNIQUE constraint using @renamed annotation, psqldef was incorrectly generating DROP CONSTRAINT for the unique index. PostgreSQL automatically updates constraint column references when a column is renamed, so this DROP was unnecessary and caused the constraint to be lost. The fix checks if the column was renamed from the name referenced by the unique index, treating renamed columns as matching.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
gfx
approved these changes
Jan 8, 2026
Contributor
|
Thanks! Please merge it by yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When renaming a column with an inline
UNIQUEconstraint using the@renamedannotation, psqldef was incorrectly generatingDROP CONSTRAINTfor the unique index. This caused the UNIQUE constraint to be lost after applying the migration.Problem
PostgreSQL automatically updates constraint column references when a column is renamed via
ALTER TABLE ... RENAME COLUMN. Therefore, theDROP CONSTRAINTgenerated by psqldef was unnecessary and resulted in data integrity loss.Before this fix:
After this fix:
Changes
generateDDLsForAbsentIndexinschema/generator.goto check if a column was renamed from the name referenced by the unique indexRenameColumnWithInlineUniqueConstraintto verify the fixTesting