Skip to content

Add support for installing the development branch#1554

Merged
potatoqualitee merged 3 commits intodataplat:developmentfrom
alevyinroc:devinstall
Jul 3, 2017
Merged

Add support for installing the development branch#1554
potatoqualitee merged 3 commits intodataplat:developmentfrom
alevyinroc:devinstall

Conversation

@alevyinroc
Copy link
Contributor

@alevyinroc alevyinroc commented Jul 3, 2017 •
edited by olegstrutinskii
Loading

Change casing to match other dbatools cmdlets, add support for WhatIf and Verbose, allow user to select the development branch

Fixes #

Changes proposed in this pull request:

  • Add Whatif support to Update-DbaTools
  • Add support for installing the beta/dev release of dbatools

How to test this code:

  • Update-DbaTools -dev (should install the current development branch)
  • Update-DbaTools (should install the latest released version)

Has been tested on minimum requirements:

  • Powershell 3
  • Windows 7
  • SQL Server 2000

Has been tested on maximum requirements:

  • SQL Server vNext
  • Windows 10
  • Azure Database

Tests for tester:

  • [X ] Working/useful help content, including link to command on dbatools web site
  • All examples work as advertised
  • Does not contain template content
  • Does not contain excessive/unnecessary amounts of comments
  • Works remotely
  • Works locally
  • Works on lower versions or throws error specifying version not supported
  • Works with named instances
  • Works with clustered instances
  • Handles offline/read only databases
  • Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
  • No un-handled errors which stop the command working with multiple servers

@alevyinroc
Add support for installing the development branch
5e45b65 
Change casing to match other dbatools cmdlets, add support for `WhatIf` and `Verbose`, allow user to select the development branch
@potatoqualitee
Copy link
Member

potatoqualitee commented Jul 3, 2017

Nice! Thank you 🌻

Please add some examples and the .PARAMETER help.

Here's some common helps:

.PARAMETER WhatIf
			Shows what would happen if the command were to run. No actions are actually performed.

		.PARAMETER Confirm
			Prompts you for confirmation before executing any changing operations within the command.

potatoqualitee
potatoqualitee approved these changes Jul 3, 2017
View reviewed changes
Copy link
Member

@potatoqualitee potatoqualitee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good as hell! merging

@potatoqualitee potatoqualitee merged commit 8890d12 into dataplat:development Jul 3, 2017
@potatoqualitee
Copy link
Member

potatoqualitee commented Jul 3, 2017

great work! 💃 💃 💃

@alevyinroc alevyinroc deleted the devinstall branch July 3, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potatoqualitee potatoqualitee potatoqualitee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alevyinroc @potatoqualitee