Make shortcut for referencing params of the current function work. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
havent had a chance to look yet..will try to get to it by the weekend |
24 tasks
harshil21
reviewed
Oct 24, 2021
Contributor
|
i just pushed 670f520 can you take a look |
Contributor
Author
|
Didn't run it, but the additional sanity check looks reasonable 👍 |
Contributor
|
thank you! |
Contributor
Author
|
My pleasure :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
I built the slqachlemy docs with this change. It worked fine and I didn't see any additional warnings/errors. There are probably still some cases where this doesn't suffice but at least I'm rather sure that it doesn't make things worse :)