PR: Ignore PySide6 QSqlDatabase.exec DeprecationWarning#506
Merged
dalthviz merged 1 commit intospyder-ide:masterfrom Dec 16, 2024
Merged
PR: Ignore PySide6 QSqlDatabase.exec DeprecationWarning#506dalthviz merged 1 commit intospyder-ide:masterfrom
QSqlDatabase.exec DeprecationWarning#506dalthviz merged 1 commit intospyder-ide:masterfrom
Conversation
Member
|
Hi @juliangilbey thanks for the PR! So my guess is that doing something like: def prevent_warn_exec(self, *args, **kwargs):
with warnings.catch_warnings():
warnings.simplefilter("ignore")
self.exec(*args, **kwargs)
QSqlDatabase.exec_ = QSqlDatabase.exec = prevent_warn_execDidn't work, right? If that is the case then seems reasonable to just ignore the warning. Also what do you think @ccordoba12 ? |
QSqlDatabase.exec DeprecationWarning
QSqlDatabase.exec DeprecationWarningQSqlDatabase.exec DeprecationWarning
Member
|
Note: More info on the deprecation at https://doc.qt.io/qt-6/qsqldatabase-obsolete.html#exec |
Member
I think we shouldn't ignore the warning with the approach you proposed so that users actually see it and learn that calling So, I'm ok with @juliangilbey's simple approach of ignoring the warning in our tests so they pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the package tests with PySide 6, the tests fail because PySide 6 gives a DeprecationWarning, and the pytest.ini settings turn this into an error. This PR ignores that specific error.
I tried using a
warnings.catch_warnings()block inqtpy/QtSql.pyaround the deprecated functions, but pytest seems to ignore this. It might be worth adding such a block anyway.