PR: Add QtCore.Qt.MouseButton.MidButton alias for Qt6#475
Merged
ccordoba12 merged 3 commits intomasterfrom Oct 24, 2024
Merged
Conversation
If QtCore.Qt.MidButton works with QtPy and Qt6, then QtCore.Qt.MouseButton.MidButton is expected to work as well.
dalthviz
reviewed
Apr 10, 2024
Member
dalthviz
left a comment
There was a problem hiding this comment.
Hi @PierreRaybaut ! Sorry for the late response and thank you for the fix! Could you also add the alias to the test at
qtpy/qtpy/tests/test_qtcore.py
Lines 172 to 190 in 3238de7
?
Other than that this LGTM 👍 Thanks again!
Member
|
@dalthviz, please push to this PR the fix you mentioned so we can include it in 2.4.2. |
QtCore.Qt.MouseButton.MidButton alias for Qt6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If QtCore.Qt.MidButton works with QtPy and Qt6, then QtCore.Qt.MouseButton.MidButton is expected to work as well.