PR: Add mappings for deprecated QDropEvent pos and posF methods#445
Merged
ccordoba12 merged 2 commits intospyder-ide:masterfrom Aug 17, 2023
Merged
PR: Add mappings for deprecated QDropEvent pos and posF methods#445ccordoba12 merged 2 commits intospyder-ide:masterfrom
QDropEvent pos and posF methods#445ccordoba12 merged 2 commits intospyder-ide:masterfrom
Conversation
f5d2fe4 to
8eb2975
Compare
QDropEvent pos and posF methodsQDropEvent pos and posF methods
Member
|
@dalthviz, I only have one question for you: will this fix the bug reported in spyder-ide/qtconsole#583? |
Member
Author
|
@ccordoba12 I believe so. With the changes here the |
ccordoba12
reviewed
Aug 17, 2023
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mappings for
posandposFforQDropEventalso affect child classes (QDragMoveEvent,QDragEnterEvent). A mapping to havepositionover Qt5 bindings is done too.Part of #442