PR: Enable more tests on CI#434
Conversation
|
I have hope that I found all test to uncomment. |
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @Czaki for working on this! Checking seems like maybe there is just one more test which skip on linux could be removed:
qtpy/qtpy/tests/test_compat.py
Line 12 in 1874fba
Other than that this LGTM 👍
However, just in case, what do you think @CAM-Gerlach and @ccordoba12 ?
|
I have removed it and all Linux test pass :) |
ccordoba12
left a comment
There was a problem hiding this comment.
Left a small question, otherwise looks good to me.
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @Czaki for your help with this!
|
Merge (to unblock the second PR)? |
|
Sure, let's do it! I was waiting for @dalthviz, but since he's not available this week and this doesn't affect the library itself, I think it's fine to proceed. |
In this PR I have added installation of libs required by qt to setup
QApplication. For this, I have usedtlambert03/setup-qt-libs@v1. This action is used in few projects testing Qt (like napari) so if new Qt version requires some additional library it will be added without the need to make such a patch in all projects.