PR: Rename utils.py to _utils.py to make it private#431
Merged
dalthviz merged 1 commit intospyder-ide:masterfrom Jul 4, 2023
Merged
PR: Rename utils.py to _utils.py to make it private#431dalthviz merged 1 commit intospyder-ide:masterfrom
utils.py to _utils.py to make it private#431dalthviz merged 1 commit intospyder-ide:masterfrom
Conversation
utils.py → _utils.py to make it privateutils.py to _utils.py to make it private
dalthviz
approved these changes
May 18, 2023
Contributor
Author
|
Please forgive me for being impatient, but it's been 45 days since last activity here. The change I propose is trivial. I understand that everyone's busy with the work they're paid for. I have another PR (about |
Member
|
Sorry @StSav012 ! This fall through the cracks 😅 Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the #422 (comment), I renamed
utils.py.As for renaming the
_wrap_missing_optional_dep_errorfunction, I'm unsure. It's only usage is in thegetattr_missing_optional_depfunction, which is in the same file and immediately follows the former. The underscore conveniently emphasizes that the_wrap_missing_optional_dep_errorfunction is not used outside the file. I'd rather stick to @DaelonSuzuka's decision.