Skip to content

PR: Update coveralls config (CI)#428

Merged
dalthviz merged 6 commits intospyder-ide:masterfrom
dalthviz:coverage_update
Nov 3, 2023
Merged

PR: Update coveralls config (CI)#428
dalthviz merged 6 commits intospyder-ide:masterfrom
dalthviz:coverage_update

Conversation

@dalthviz
Copy link
Copy Markdown
Member

Fixes #426

@dalthviz dalthviz added this to the v2.4.0 milestone Apr 14, 2023
@dalthviz dalthviz self-assigned this Apr 14, 2023
@dalthviz dalthviz changed the title [WIP] PR: Remove basedir flag for coverage command (CI) [WIP] PR: Update basedir flag for coverage command (CI) Apr 14, 2023
@dalthviz dalthviz changed the title [WIP] PR: Update basedir flag for coverage command (CI) [WIP] PR: Update coveralls command config (CI) Apr 14, 2023
Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments

@dalthviz dalthviz modified the milestones: v2.4.0, v2.4.1 Aug 11, 2023
@dalthviz dalthviz modified the milestones: v2.4.1, v2.4.2 Oct 16, 2023
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@dalthviz dalthviz marked this pull request as ready for review October 27, 2023 22:25
@dalthviz dalthviz changed the title [WIP] PR: Update coveralls command config (CI) PR: Update coveralls config (CI) Oct 27, 2023
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@dalthviz
Copy link
Copy Markdown
Member Author

dalthviz commented Nov 1, 2023

Is okay if we merge this one @CAM-Gerlach ? Or do you think something is missing?

@dalthviz
Copy link
Copy Markdown
Member Author

dalthviz commented Nov 3, 2023

Going ahead and merging this. However, if there are things that needed to be further worked on, let me know

@dalthviz dalthviz merged commit 865fb47 into spyder-ide:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coveralls config needs to be updated

3 participants