PR: Add QEnum macro for PyQt bindings#424
Conversation
|
Thanks. Seems like @dalthviz , thoughts? |
|
According to docs, it should have been added to Qt5.5 already. (https://doc.qt.io/qt-5/whatsnew55.html) |
b6a9488 to
f2097d1
Compare
|
Tried adding a fallback for 5.9. EDIT: checks are passing now. |
|
To note, at least judging by what we've done in the past, it even can be pretty simple—even just an existence check on |
77e1ec9 to
43a60a2
Compare
|
Note: The errors in the tests come from pypa/pip#11975 and are unrelated to the changes done here |
|
Note: Re-running the CI checks shows that there is an error with PySide2 ( |
|
Will take a look again when I find some time. |
|
Just a note here in case it helps, the |
|
Hi @phil65 sorry for the sudden ping, just wondering, is it okay if I try to finish this? Let us know! |
QEnum macro for PyQt bindings
|
I will try to finish this so please @phil65 don't push any other commit to your branch :) |
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @phil65!
|
Is it okay if we merge this one @CAM-Gerlach ? |
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Checking the very minor changes since my last approval, they all LGTM, thanks—sorry for the delay!
synchronizes macro naming with PySide