PR: Symmetrize path and location of QLibraryInfo#420
Conversation
|
The related SO topic doesn't seem to help. |
path and location of QLibraryInfopath and location of QLibraryInfo
|
NB @dalthviz , this job seems to fail every other run, with re-running fixing it. Maybe some kind of caching issue? I looked into it previously but wasn't totally sure what was going on. |
Not sure either 🤔 maybe opening an issue to track that some flakiness there exists is worthy? |
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @StSav012 ! LGTM 👍
What do you think @CAM-Gerlach @ccordoba12 ?
CAM-Gerlach
left a comment
There was a problem hiding this comment.
I'd defer to your expertise here @dalthviz and @ccordoba12 , but LGTM from my side for what its worth.
Yeah, I can do that next time I see it fail. |
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @StSav012!
More and more code is initially written for Qt6 and then required to run on Qt5. There are many things introduced or renamed in Qt6. One of them is
QLibraryInfo.location→QLibraryInfo.pathandQLibraryInfo.LibraryLocation→QLibraryInfo.LibraryPath.Following #393, I'd like to port
QLibraryInfo.pathandQLibraryInfo.LibraryPathback to Qt5. This way, all the supported flavors haveQLibraryInfo.location,QLibraryInfo.path,QLibraryInfo.LibraryLocation, andQLibraryInfo.LibraryPathaltogether.