PR: Make QtBindingsNotFoundError also inherit from ImportError#413
PR: Make QtBindingsNotFoundError also inherit from ImportError#413dalthviz merged 1 commit intospyder-ide:masterfrom
QtBindingsNotFoundError also inherit from ImportError#413Conversation
QtBindingsNotFoundError inherit from ImportError
|
Seems like the tests are failing because QtPositioning is no longer included in |
|
I think is okay to skip it 👍 We could use as validation for the skip the Lines 9 to 13 in e7a7060 And adding in the reason the link to the PR you shared. Would you like to help adding the skip @CAM-Gerlach ? |
|
PR #414 is now merged! 🎉 |
358ee81 to
2f04efa
Compare
|
I've gone ahead and used GItHub's built-in "Update Branch" button to update this. @cbrnr , if you need to pull the changes locally, you'll need to do: git fetch origin
git reset --hard origin/qtbindingsnotfounderror |
QtBindingsNotFoundError inherit from ImportErrorQtBindingsNotFoundError also inherit from ImportError
In addition to
PythonQtError,QtBindingsNotFoundErrornow also inherits fromImportError. This should be easier to catch from outside than a genericRuntimeError.Fixes #412.