Skip to content

PR: Remove patch that may be limited to PySide-5.11a1 only#407

Merged
dalthviz merged 1 commit intospyder-ide:masterfrom
StSav012:patch-1
Feb 14, 2023
Merged

PR: Remove patch that may be limited to PySide-5.11a1 only#407
dalthviz merged 1 commit intospyder-ide:masterfrom
StSav012:patch-1

Conversation

@StSav012
Copy link
Copy Markdown
Contributor

The removal looks safe, provided the oldest supported PySide2 is 5.12.

See #405

@StSav012 StSav012 marked this pull request as ready for review February 11, 2023 12:01
@CAM-Gerlach CAM-Gerlach linked an issue Feb 14, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @StSav012

@CAM-Gerlach CAM-Gerlach requested a review from dalthviz February 14, 2023 06:27
@CAM-Gerlach CAM-Gerlach changed the title Remove patch that “may be limited to PySide-5.11a1 only” PR: Remove patch that may be limited to PySide-5.11a1 only Feb 14, 2023
@dalthviz dalthviz added this to the v2.3.1 milestone Feb 14, 2023
Copy link
Copy Markdown
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StSav012 !

@dalthviz dalthviz merged commit 6f7e1e7 into spyder-ide:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove patch that "may be limited to PySide-5.11a1 only"

3 participants