Simplify CI script following Qt 5.15.6 feedstock update#397
Merged
dalthviz merged 1 commit intospyder-ide:masterfrom Jan 13, 2023
CAM-Gerlach:update-qt-pinning-ci
Merged
Simplify CI script following Qt 5.15.6 feedstock update#397dalthviz merged 1 commit intospyder-ide:masterfrom CAM-Gerlach:update-qt-pinning-ci
dalthviz merged 1 commit intospyder-ide:masterfrom
CAM-Gerlach:update-qt-pinning-ci
Conversation
ccordoba12
approved these changes
Jan 12, 2023
Member
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @CAM-Gerlach!
hmaarrfk
reviewed
Jan 13, 2023
hmaarrfk
reviewed
Jan 13, 2023
Contributor
|
I'm trying to keep up with qt (and tried to get some help from the bot more recently) but there are just more eyes on the qt-main and qt-webengine feedstocks. |
dalthviz
approved these changes
Jan 13, 2023
Member
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @CAM-Gerlach ! LGTM 👍
Also, thank you @hmaarrfk for the review! If you have any other suggestions or questions you want to discuss let us know!
Member
Author
And by the way, thanks so much for your help with all that @hmaarrfk ! |
This was referenced Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #392
As conda-forge/qt-feedstock#234 seems to be resolved by way of conda-forge/qt-feedstock#235 , we can now remove the workaround in our CI needed for that issue, which re-simplifies the script quite a bit.