PR: Raise error when no bindings are found at __init__#379
PR: Raise error when no bindings are found at __init__#379dalthviz merged 2 commits intospyder-ide:masterfrom
__init__#379Conversation
ccordoba12
left a comment
There was a problem hiding this comment.
I have a small doubt about this (mentioned below), otherwise looks good to me.
cd636f7 to
f6a3ffd
Compare
ccordoba12
left a comment
There was a problem hiding this comment.
Great work, thanks @dalthviz!
|
Note: This is missing and update to take into account the modules added at PR #382 |
Co-authored-by: tgwoodcock <tgwoodcock@users.noreply.github.com>
f6a3ffd to
5b0846a
Compare
5b0846a to
83e31a0
Compare
|
Merging this to proceed with the release |
|
Sorry I didn't get the chance to review this at the time. The correct fix (using Here's how the error output looks now: >>> import qtpy.QtCore
Traceback (most recent call last):
File "C:\Users\C. A. M. Gerlach\Documents\dev\SpyderDev\qtpy\qtpy\__init__.py", line 252, in <module>
from PySide6 import __version__ as PYSIDE_VERSION # analysis:ignore
ModuleNotFoundError: No module named 'PySide6'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Users\C. A. M. Gerlach\Documents\dev\SpyderDev\qtpy\qtpy\__init__.py", line 259, in <module>
raise QtBindingsNotFoundError()
qtpy.QtBindingsNotFoundError: No Qt bindings could be foundand here's how it should look with the correct >>> import qtpy.QtCore
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Users\C. A. M. Gerlach\Documents\dev\SpyderDev\qtpy\qtpy\__init__.py", line 259, in <module>
raise QtBindingsNotFoundError from None
qtpy.QtBindingsNotFoundError: No Qt bindings could be found |
Following suggestion at #367 (comment) by @tgwoodcock
Fixes #367