Skip to content

PR: Expand the CI test matrix with Qt/bindings 6.4 and fix tests with PyQt 5.9#376

Merged
ccordoba12 merged 2 commits intospyder-ide:masterfrom
CAM-Gerlach:ci-expand-matrix
Nov 1, 2022
Merged

PR: Expand the CI test matrix with Qt/bindings 6.4 and fix tests with PyQt 5.9#376
ccordoba12 merged 2 commits intospyder-ide:masterfrom
CAM-Gerlach:ci-expand-matrix

Conversation

@CAM-Gerlach
Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach commented Oct 17, 2022 •
edited by dalthviz
Loading

I will push to and test this incrementally, starting with setting one job to 6.4 for bindings and Qt, and see how things go. If we need to fix a lot of failures (which I might need your help on @dalthviz ), we can merge this once that's done and then add the optional deps in a separate PR, since that can be significantly more complex.

Fixes #375
Part of #345

@CAM-Gerlach CAM-Gerlach self-assigned this Oct 17, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 17, 2022
Closed
@dalthviz
Copy link
Copy Markdown
Member

dalthviz commented Oct 18, 2022

Thanks for the help with this @CAM-Gerlach ! After a quick review seems like this also has things related with #345 right?

Regarding the failing test I think is related with QtCore.QLibraryInfo.location being deprecated. I think we will need to aliase the QtCore.QLibraryInfo.location with something like: the following over the PYSIDE6 if:

QLibraryInfo.location = QLibraryInfo.path

@dalthviz dalthviz added this to the v2.3.0 milestone Oct 18, 2022
@dalthviz dalthviz mentioned this pull request Oct 18, 2022
Closed
@dalthviz dalthviz changed the title Expand the CI test matrix with Qt/bindings 6.4 and optional modules PR: Expand the CI test matrix with Qt/bindings 6.4 and optional modules Oct 27, 2022
@dalthviz dalthviz changed the title PR: Expand the CI test matrix with Qt/bindings 6.4 and optional modules PR: Expand the CI test matrix with Qt/bindings 6.4/optional modules and fix tests with PyQt 5.9 Oct 27, 2022
@dalthviz dalthviz modified the milestones: v2.3.0, v2.2.2 Oct 31, 2022
@dalthviz dalthviz changed the title PR: Expand the CI test matrix with Qt/bindings 6.4/optional modules and fix tests with PyQt 5.9 PR: Expand the CI test matrix with Qt/bindings 6.4 and fix tests with PyQt 5.9 Nov 1, 2022
@dalthviz dalthviz self-assigned this Nov 1, 2022
@dalthviz dalthviz marked this pull request as ready for review November 1, 2022 00:42
@dalthviz dalthviz requested a review from ccordoba12 November 1, 2022 00:42
ccordoba12
ccordoba12 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @CAM-Gerlach and @dalthviz!

It seems this has the initial steps to add pre-commit to this repo, but I see no harm in including them for now.

@ccordoba12 ccordoba12 merged commit 3a70541 into spyder-ide:master Nov 1, 2022
@CAM-Gerlach
Copy link
Copy Markdown
Member Author

CAM-Gerlach commented Dec 16, 2022 •
edited
Loading

It seems this has the initial steps to add pre-commit to this repo, but I see no harm in including them for now.

Oops...I had another branch in progress adding pre-commit based on the config in our other repos, but it seems because those were new/untracked files I accidentally committed them to the wrong branch when I was working on this, and then got busy with the Python 3.11 release and didn't notice my WiP config was added here. Sorry about that and thanks @dalthviz for finishing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

@CAM-Gerlach CAM-Gerlach

Labels

type:Task

Projects

None yet

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

Test PySide6 6.4.x

3 participants

@CAM-Gerlach @dalthviz @ccordoba12