PR: Aliased QUndoCommand, provided QLineEdit.getTextMargins() and QFontMetricsF.width()#366
Merged
dalthviz merged 3 commits intospyder-ide:masterfrom Sep 5, 2022
Conversation
QUndoCommand, provided QLineEdit.getTextMargins() and QFontMe…
QUndoCommand, provided QLineEdit.getTextMargins() and QFontMe…QUndoCommand, provided QLineEdit.getTextMargins() and QFontMetricsF.width()
dalthviz
reviewed
Sep 2, 2022
Member
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @random-developer for your help with this! I think the only missing thing here is to add some testing:
- For
QtWidgets.QUndoCommandandQtWidgets.QLineEdit.getTextMarginsat: https://github.com/spyder-ide/qtpy/blob/master/qtpy/tests/test_qtwidgets.py - For
QtGui.QFontMetricsF.widthat: https://github.com/spyder-ide/qtpy/blob/master/qtpy/tests/test_qtgui.py similar toLines 14 to 20 in fdd6818
Other than that this looks good to me 👍
Contributor
Author
|
The QUndoCommand test is failing. I'm not sure why; will investigate later; too pressed for time right now. |
dalthviz
reviewed
Sep 2, 2022
dd4ab16 to
4430e95
Compare
4430e95 to
458e3de
Compare
dalthviz
approved these changes
Sep 5, 2022
Member
dalthviz
left a comment
There was a problem hiding this comment.
Thanks @random-developer ! This LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365