Skip to content

PR: Restore WEBENGINE constant in QtWebEngineWidgets#350

Merged
dalthviz merged 1 commit intospyder-ide:masterfrom
ccordoba12:restore-webengine-constant
Jun 13, 2022
Merged

PR: Restore WEBENGINE constant in QtWebEngineWidgets#350
dalthviz merged 1 commit intospyder-ide:masterfrom
ccordoba12:restore-webengine-constant

Conversation

@ccordoba12
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 commented Jun 13, 2022

This constant was removed in PR #344, but it's used by external projects (e.g. Spyder). So, they would break if they can't find it.

@ccordoba12 ccordoba12 added this to the v2.2.0 milestone Jun 13, 2022
@ccordoba12 ccordoba12 requested a review from dalthviz June 13, 2022 15:07
@ccordoba12 ccordoba12 self-assigned this Jun 13, 2022
Copy link
Copy Markdown
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 LGTM 👍

@dalthviz dalthviz merged commit 246dab0 into spyder-ide:master Jun 13, 2022
@ccordoba12 ccordoba12 deleted the restore-webengine-constant branch June 13, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants