Skip to content

PR: Change bindings try order to be PyQt5, PySide2, PyQt6, PySide6#343

Merged
ccordoba12 merged 1 commit intospyder-ide:masterfrom
dalthviz:fixes_issue_342
Apr 29, 2022
Merged

PR: Change bindings try order to be PyQt5, PySide2, PyQt6, PySide6#343
ccordoba12 merged 1 commit intospyder-ide:masterfrom
dalthviz:fixes_issue_342

Conversation

@dalthviz
Copy link
Copy Markdown
Member

Fixes #342

@dalthviz dalthviz added this to the v2.1.0 milestone Apr 28, 2022
@dalthviz dalthviz requested a review from ccordoba12 April 28, 2022 16:47
@dalthviz dalthviz self-assigned this Apr 28, 2022
@dalthviz dalthviz changed the title PR: Change bindings 'try order' to be PyQt5, PySide2, PyQt6, PySide6 PR: Change bindings try order to be PyQt5, PySide2, PyQt6, PySide6 Apr 28, 2022
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit f466699 into spyder-ide:master Apr 29, 2022
@ccordoba12
Copy link
Copy Markdown
Member

Note: Please don't forget to mention this in our Changelog for 2.1.0 because it could catch people off guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change bindings try order to follow QtPy v1.x convention

2 participants